messageLogger: fix niche bug ignoring edits when content is same #2403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
eta wen |
Vendicated
changed the title
mantikafasi
pushed a commit
to StupidityDB/VencordPlus
that referenced
this pull request
May 5, 2024
* ResurrectHome: Fix patch * RoleColorEverywhere: Actually fix patch * NoTrack: Option to keep analytics, improve patches * improve contributor modal & badge * fix FriendsSince * refactor(Webpack): more reliable patching (Vendicated#2237) * messageLogger: fix niche bug ignoring edits when content is same (Vendicated#2403) * feat(plugin): PauseInvitesForever (Vendicated#2372) Co-authored-by: V <vendicated@riseup.net> * MoreUserTags: Remove old workaround; MessageClickActions: Move finds outside of start * fix sort conflict of ImplicitRelationships & SortFriendRequests (Vendicated#2408) * ReviewDB: add more context menu shortcuts to view reviews (Vendicated#2382) Co-authored-by: V <vendicated@riseup.net> * feat(USRBG): update to new API (Vendicated#2388) * MsgClickActions: control ping via shift & NoReplyMention plugin (Vendicated#2390) Co-authored-by: V <vendicated@riseup.net> * fix badges with custom component * feat(plugin): ImageLink (Vendicated#2297) * Test Patches: Faster chromium setup; Update action versions (Vendicated#2412) * Test Patches: Remove pnpm add puppeteer as it's already in deps * SecretRingToneEnabler: Fix patch * feat(ValidUser): also display badges & banner (Vendicated#2235) Co-authored-by: V <vendicated@riseup.net> * NewGuildSettings: add push notifs, highlights & events (Vendicated#2413) Co-authored-by: V <vendicated@riseup.net> * fix overflow when having two rows of badges * Future proof FakeNitro and Experiments to not brick Discord startup * bump to v1.8.1 --------- Co-authored-by: Nuckyz <61953774+Nuckyz@users.noreply.github.com> Co-authored-by: Vendicated <vendicated@riseup.net> Co-authored-by: HAHALOSAH <67280050+HAHALOSAH@users.noreply.github.com> Co-authored-by: dolfies <jeyalfie47@gmail.com> Co-authored-by: Sqaaakoi <sqaaakoi-git@sqaaakoi.xyz> Co-authored-by: katlyn <17418611+katlyn@users.noreply.github.com> Co-authored-by: sunnie <78964224+sunnniee@users.noreply.github.com> Co-authored-by: Kyuuhachi <1547062+Kyuuhachi@users.noreply.github.com> Co-authored-by: Gabriel Ruiz Pérez <57387907+GabiRP@users.noreply.github.com>
LunaisLazier
pushed a commit
to LunaisLazier/Mooncord
that referenced
this pull request
May 7, 2024
LunaisLazier
pushed a commit
to LunaisLazier/Mooncord
that referenced
this pull request
May 13, 2024
…ame (Vendicated#2403)" This reverts commit 85d6d74. As suspected, this code was actually necessary
lillithkt
pushed a commit
to lillithkt/Vencord
that referenced
this pull request
May 27, 2024
lillithkt
pushed a commit
to lillithkt/Vencord
that referenced
this pull request
May 27, 2024
…ame (Vendicated#2403)" This reverts commit 85d6d74. As suspected, this code was actually necessary
Autumnlight02
pushed a commit
to Autumnlight02/Vencord
that referenced
this pull request
Jun 4, 2024
Autumnlight02
pushed a commit
to Autumnlight02/Vencord
that referenced
this pull request
Jun 4, 2024
…ame (Vendicated#2403)" This reverts commit 85d6d74. As suspected, this code was actually necessary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the redundant check
$2.message.content !== m.editHistory?.[0]?.contentwhich checks if the new message content is different from the first item in the editHistory. This is not needed (there is another check$2.message.content !== m.content), and results in a bug; the other check should be sufficient.Fixes #2395.